A storage bench should be made approximately 24" tall. To verify the height of your bench, find a comfortable seat in your house and measure the height of the seat. Simply make your bench the same height.
It should be tall enough to allow for people to put their feet down and touch the ground. It should not be too tall and make people's feet not touch the ground.